🐛 Fix highlight alignment in emojified gin-log #117
Conversation
WalkthroughThe recent update introduces a conditional feature in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- denops/gin/command/buffer/edit.ts (1 hunks)
Additional comments: 2
denops/gin/command/buffer/edit.ts (2)
100-100: The conditional application of the
emojifyfunction to thecontentarray is a logical way to handle the emojification based on theoptions.emojifyflag. This should ensure that the text is only emojified when the option is enabled, which aligns with the PR objectives.105-105: The replacement of the
trimmedarray with the emojifiedcontentis crucial for the fix. However, it's important to verify that this change does not affect other parts of the code wheretrimmedmight be used in its original, unemojified form.Verification successful
The verification process has confirmed that the
trimmedvariable is used immediately after its definition and conditional modification within theexecfunction. There is no evidence from the provided context thattrimmedis used elsewhere in a way that would conflict with the change to applyemojifyconditionally. The change appears to be safely contained within the local scope of theexecfunction.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the 'trimmed' variable is not used elsewhere in a way that requires it to be unemojified. rg --type ts "trimmed" --context 5 "denops/gin/command/buffer/edit.ts"Length of output: 424
|
I'll merge it once the CI passed (let me know if I forget) |
|
@lambdalisue Could you check the CI results? |
This fixes highlight alignment in emojified gin-log buffer.
Before fix: Misalignment of highlights in emojified text.
After fix: Correct alignment of highlights in emojified text.
Summary by CodeRabbit